Add event sampling. Name threads #43
Conversation
|
wrong base branch |
| compile "com.google.guava:guava:19.0" | ||
| compile "org.slf4j:slf4j-api:1.7.7" | ||
| compile "com.launchdarkly:okhttp-eventsource:0.1.0" | ||
| compile group: "com.launchdarkly", name: "okhttp-eventsource", version: "0.1.3-SNAPSHOT", changing: true |
There was a problem hiding this comment.
What does this do exactly? Never encountered this before.
There was a problem hiding this comment.
In short it goes with the addition on lines 8-12. We're instructing gradle to always go look in a repo for the latest version of this dep. When this is pinned to a stable 1.0.0 it won't be needed, but is very handy for local development and potentially build/deploy systems that that might have older snapshots cached.
I am not a gradle expert, so this might not be the best way to do it.
|
Yah, realized that after making a few comments. Can you re-target the other branch? |
|
Github won't let you do this: http://stackoverflow.com/questions/24159036/how-to-modify-a-pull-request-on-github-to-change-target-branch-to-merge-into I'll address your comments here and in the correct one. |
|
Yep. We usually just close the PR and open a new one. BTW, BitBucket does On Sat, Apr 9, 2016 at 9:26 AM, Dan Richelson notifications@github.com
|
|
#44 has the correct target branch |
support segments (with genericized feature store)
No description provided.